Skip to content

Make network interface reconcile/delete async#1939

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Jont828:async-networkinterfaces
Jan 24, 2022
Merged

Make network interface reconcile/delete async#1939
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Jont828:async-networkinterfaces

Conversation

@Jont828
Copy link
Copy Markdown
Contributor

@Jont828 Jont828 commented Dec 18, 2021 •
edited
Loading

What type of PR is this?

/kind feature
What this PR does / why we need it: Implementation of an async service for network interfaces as part of an effort to make all services async. See #1610 and #1541.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1717

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Make network interfaces reconcile/delete async

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 18, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 18, 2021

Hi @Jont828. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 18, 2021
@Jont828 Jont828 mentioned this pull request Dec 22, 2021
Closed
7 tasks
@shysank
Copy link
Copy Markdown
Contributor

shysank commented Jan 6, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 6, 2022
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Jan 8, 2022

comment from @shysank about using named returns from another PR that is relevant here:
#1686 (comment)

Here is the commit that does this in the route tables PR: b2302ea

@Jont828 Jont828 force-pushed the async-networkinterfaces branch from 038e548 to 9c776e5 Compare January 10, 2022 19:16
@Jont828 Jont828 changed the title Make network interface reconcile/delete async [WIP] Make network interface reconcile/delete async Jan 10, 2022
mboersma
mboersma reviewed Jan 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! There is still a comment in machine_test.go about adding another test case:
// TODO: add a test for when the cache is not empty

Comment thread azure/services/networkinterfaces/client.go Outdated
Comment thread azure/services/networkinterfaces/client.go Outdated
@Jont828 Jont828 force-pushed the async-networkinterfaces branch 4 times, most recently from 6398aa4 to 17da1ea Compare January 14, 2022 20:37
@Jont828
Copy link
Copy Markdown
Contributor Author

Jont828 commented Jan 18, 2022

/retest

CecileRobertMichon
CecileRobertMichon reviewed Jan 19, 2022
View reviewed changes
Comment thread azure/scope/machine.go Outdated
CecileRobertMichon
CecileRobertMichon reviewed Jan 19, 2022
View reviewed changes
Comment thread azure/scope/machine.go Outdated
CecileRobertMichon
CecileRobertMichon reviewed Jan 19, 2022
View reviewed changes
Comment thread azure/services/networkinterfaces/networkinterfaces.go Outdated
@Jont828 Jont828 force-pushed the async-networkinterfaces branch from 17da1ea to 6d4c831 Compare January 19, 2022 22:38
CecileRobertMichon
CecileRobertMichon reviewed Jan 19, 2022
View reviewed changes
Comment thread azure/scope/machine.go Outdated
CecileRobertMichon
CecileRobertMichon reviewed Jan 20, 2022
View reviewed changes
Comment thread api/v1beta1/conditions_consts.go
@Jont828
Copy link
Copy Markdown
Contributor Author

Jont828 commented Jan 21, 2022

/retest

@Jont828 Jont828 force-pushed the async-networkinterfaces branch from 45ff794 to df8eb5a Compare January 21, 2022 00:40
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

CecileRobertMichon commented Jan 21, 2022

/retest

CecileRobertMichon
CecileRobertMichon reviewed Jan 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@Jont828
Copy link
Copy Markdown
Contributor Author

Jont828 commented Jan 21, 2022

/retest

1 similar comment
@Jont828
Copy link
Copy Markdown
Contributor Author

Jont828 commented Jan 24, 2022

/retest

@Jont828 Jont828 force-pushed the async-networkinterfaces branch from df8eb5a to ca6f620 Compare January 24, 2022 18:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
CecileRobertMichon
CecileRobertMichon reviewed Jan 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2022
@Jont828 Jont828 force-pushed the async-networkinterfaces branch from ca6f620 to 107468d Compare January 24, 2022 21:36
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 24, 2022
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 24, 2022 •
edited
Loading

@Jont828: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-apidiff 107468d link false /test pull-cluster-api-provider-azure-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CecileRobertMichon
CecileRobertMichon reviewed Jan 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1679861 into kubernetes-sigs:main Jan 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboersma mboersma mboersma left review comments

@alexeldeib alexeldeib Awaiting requested review from alexeldeib

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

+1 more reviewer

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@CecileRobertMichon CecileRobertMichon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v1.1

Development

Successfully merging this pull request may close these issues.

async networkinterfaces

5 participants

@Jont828 @k8s-ci-robot @shysank @CecileRobertMichon @mboersma